Add multi-row deletion via context menu#158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(data-grid): multi-row deletion via context menu
Users could previously only delete one row at a time from the context menu, even when multiple
rows were selected. This change makes the context menu deletion respect the current selection.
What changed
Multi-row delete via context menu
rows" and marks all selected rows for deletion at once
row — no change to existing behaviour
are marked for deletion as before and still require an explicit save)
Bug fix: stale state overwrites
every call. In a loop this meant each call saw the same stale object and only the last pk value
survived. Fixed by collecting all pk values first and applying them in a single updateTab call
via the new onMarkMultipleForDeletion prop.
i18n
it, zh