Skip to content

ci: support manual prereleases built from fork PRs#206

Merged
debba merged 3 commits into
TabularisDB:mainfrom
NewtTheWolf:ci/manual-prerelease-from-pr
May 25, 2026
Merged

ci: support manual prereleases built from fork PRs#206
debba merged 3 commits into
TabularisDB:mainfrom
NewtTheWolf:ci/manual-prerelease-from-pr

Conversation

@NewtTheWolf
Copy link
Copy Markdown
Contributor

Adds workflow_dispatch inputs (pr_number, tag_name, prerelease) to the release workflow so a maintainer can build a prerelease directly from a fork PR without merging or pushing the branch upstream. When pr_number is set, checkout uses refs/pull//head; the dispatcher controls the tag and prerelease flag.

Tag names containing a "-" (semver pre-release qualifier) auto-flag the release as prerelease even without the explicit input. AUR, Snap, and Winget downstream workflows now skip when github.event.release.prerelease is true, so beta channels stay out of the system package managers.

Adds workflow_dispatch inputs (pr_number, tag_name, prerelease) to the
release workflow so a maintainer can build a prerelease directly from a
fork PR without merging or pushing the branch upstream. When pr_number
is set, checkout uses refs/pull/<N>/head; the dispatcher controls the
tag and prerelease flag.

Tag names containing a "-" (semver pre-release qualifier) auto-flag the
release as prerelease even without the explicit input. AUR, Snap, and
Winget downstream workflows now skip when github.event.release.prerelease
is true, so beta channels stay out of the system package managers.
Comment thread .github/workflows/release.yml Outdated
prerelease:
description: "Mark as prerelease (skips AUR/Snap/Winget downstream)."
type: boolean
default: false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we assume that forks will always be pre-release and not provide the option to toggle. This would make sure that the release bits are created from main source and not the fork.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i think it is better

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in 40c060c — removed the prerelease workflow input entirely and hard-coded prerelease=true on the pr_number branch. Fork PR builds can never be promoted to a full release anymore. Tag-name SemVer auto-detection still applies for tag-triggered / main-built dispatches.

Per @saurabh500's review: when pr_number is set, the build comes from
refs/pull/<N>/head (a fork) rather than main, so it must never be promoted
to a full release. Removed the prerelease workflow input entirely and
hard-code prerelease=true on the pr_number branch. Tag-name SemVer
auto-detection still applies for tag-triggered / main-built dispatches.
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 24, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .github/workflows/release.yml - Added workflow_dispatch inputs (pr_number, tag_name), meta step for ref/tag/prerelease resolution, and updated checkout/tauri-action/Windows upload to use resolved values. No issues found.
  • .github/workflows/aur.yml - Added if guard to skip prerelease releases while allowing manual workflow_dispatch override. No issues found.
  • .github/workflows/snap.yml - Added if guard to skip prerelease releases while allowing manual workflow_dispatch override. No issues found.
  • .github/workflows/winget.yml - Added if guard to skip prerelease releases. No issues found.

Reviewed by kimi-k2.6 · 86,253 tokens

@debba debba merged commit bbf73c6 into TabularisDB:main May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants