Fix filters for case-sensitive column names on PostgreSQL#232
Merged
debba merged 7 commits intoMay 21, 2026
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Resolved Issues
Other Observations (not in diff)
Files Reviewed (2 files in this incremental review)
Reviewed by kimi-k2.6 · incremental review Reviewed by kimi-k2.6-20260420 · 113,143 tokens |
After 6a4a330 made TableToolbar consume useDatabase directly, the test suite rendered the component without a DatabaseProvider, causing all 18 tests to fail. Mock the hook to return a stub with activeDriver: null so the component renders in isolation.
Collaborator
|
Hi! I fixed the failing tests in this PR. Could you please check that everything looks good before merging? The changes only touch tests, so the implementation behavior should be unchanged. |
Contributor
Author
|
I noticed the |
Collaborator
|
@m-tonon That’s great. |
Contributor
Author
|
Now it's good to go 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: quote Postgres column names in structured filters
Postgres is case-sensitive:
userIdwas becominguseridand filters failed.Now when driver = postgres, columns get double quotes via
quoteIdentifier(MySQL/SQLite unchanged).Closes #231