feat(sqlserver): data type registry + CREATE TABLE DDL#237
Merged
debba merged 1 commit intoMay 21, 2026
Merged
Conversation
…ularisDB#150) Adds src-tauri/src/drivers/sqlserver/types.rs with 34 SQL Server data types across numeric, text, unicode, binary, datetime, boolean, and spatial categories. Wires get_data_types() on SqlServerDriver to call into the new module instead of returning an empty Vec. This makes the column-type dropdown functional in the table designer for SQL Server. Implements get_create_table_sql using bracket_quote() and qualify() from helpers.rs, with IDENTITY(1,1) for auto-increment columns and a separate PRIMARY KEY clause (inline_pk = false). Updates the Phase 1 test that asserted an empty type list to assert the expected types are present. Test results: 123 passed; 0 failed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by kimi-k2.6 · 1,088,327 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populates the SQL Server data-type registry so the column-type dropdown in the table designer is functional, and implements \get_create_table_sql\ so table creation works for SQL Server.
Changes
\src-tauri/src/drivers/sqlserver/types.rs\ (new file)
34 SQL Server data types across 7 categories:
INT/BIGINT/SMALLINT/TINYINT marked \supports_auto_increment: true\ (IDENTITY). DECIMAL/NUMERIC marked
equires_precision: true. VARCHAR/NVARCHAR/CHAR/NCHAR marked
equires_length: true.
\src-tauri/src/drivers/sqlserver/mod.rs\
Test results
\
cargo test --lib drivers::sqlserver
test result: ok. 123 passed; 0 failed; 0 ignored
\\
(Was 119 before; 4 new unit tests in \ ypes.rs.)
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com