New tabs DML (Data Manipulation Language)#259
Merged
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| state: { | ||
| initialQuery: displayedSql, | ||
| queryName: `${tableName} – ${tab}`, | ||
| undefined, |
There was a problem hiding this comment.
WARNING: Stray undefined property in navigation state
The undefined identifier is being used as a shorthand property name, which evaluates to { undefined: undefined }. This is likely a leftover from removing a property and should be deleted.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (12 files)
Fix these issues in Kilo Cloud Reviewed by kimi-k2.6 · 152,263 tokens |
Collaborator
|
Hi @capvalen , thanks for this . |
Replace the '?' placeholders in the generated UPDATE statement with :named parameters derived from column names, so the SQL binds correctly when opened in the query editor. Add a toBindParamName helper that sanitises identifiers into valid :param names, with unit tests.
Collaborator
|
Hey @capvalen, I pushed a couple of small changes on top of your branch:
Both are minor. If you're good with them, I'll go ahead and merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've added new tabs for the SQL commands, placing them in the context menu of the Generate SQL tool: They are SELECT *, SELECT [fields], UPDATE, and DELETE.
The changes are located in the same Generate SQL modal.
Changes:
generateSQLsection: Keys: The
tabCreateTable,tabSelectAll,tabSelectFields,tabUpdate,tabDeleteandrunInConsoleThe result are:
Coded in Manjaro Linux.
I hope you add it to the repository. These are features that were missing and are very useful.
Thanks.
Ps. I used AI because I'm new to React. But I did run the necessary tests.