-
Notifications
You must be signed in to change notification settings - Fork 43
Change the event the PR Comment workflow runs on #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #56 +/- ##
=========================================
Coverage 48.48% 48.48%
Complexity 45 45
=========================================
Files 6 6
Lines 198 198
=========================================
Hits 96 96
Misses 102 102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeffpaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question on permissions, otherwise good to go
Description of the Change
In #46 we added a GitHub Action workflow to add a Playground testing link to each PR description. There were a few issues with that and we fixed those in #49. In testing coming out of that merge, noticing a few more problems:
trunk, even though we want it to build from the PR branchvendordirectoryFor the first, in looking at the difference between using
pull_requestandpull_request_targetas the triggering event,pull_request_target(which we were using) will always reference the PR base branch (typicallytrunkin our case) instead of the last commit to the PR branch itself.I've adjusted that in this PR to use
pull_requestinstead. I believe this is the proper event to use, especially based on this comment from GitHub:For the second issue, I've adjusted our build script to ensure the
vendordirectory is included there but only include non-dev dependencies.How to test the Change
Ensure the Playground link gets added properly to this PR description and that link works
Test using WordPress Playground
The changes in this pull request can be previewed and tested using this WordPress Playground instance:
Click here to test this pull request.