Fix: Focus loss when generation buttons enter disabled state#611
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #611 +/- ##
==========================================
Coverage 73.18% 73.18%
Complexity 1731 1731
==========================================
Files 85 85
Lines 7473 7473
==========================================
Hits 5469 5469
Misses 2004 2004
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What?
Part of #589
Why?
PR is necessary to retain visible focus indication when buttons enter disabled state during generation.
How?
Testing showed the primary user-facing issue in these cases was loss of visible focus indication during disabled states. Adding
accessibleWhenDisabledpreserves the visible focus indicator during generation.accessibleWhenDisabledprop so focus is not lost while the button goes into disabled mode during generation.Use of AI Tools
Testing Instructions
Same for Excerpt and Featured Image generation.
Changelog Entry