Fix: a11y Add focus again to Generate Title button on modal close#644
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #644 +/- ##
==========================================
Coverage 74.50% 74.50%
Complexity 1740 1740
==========================================
Files 85 85
Lines 7523 7523
==========================================
Hits 5605 5605
Misses 1918 1918
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkotter
left a comment
There was a problem hiding this comment.
This works, as far as bringing focus back to the button but I think a better experience is to bring focus back to the title input, which should automatically trigger the showing of the button.
As an example, if I click Generate Title and then click somewhere else while the generation is happening (say into a paragraph block) the modal eventually shows and once I close out the modal, my cursor remains in the paragraph block but the generate button is showing, even though focus isn't in the title input. So I'd suggest we move focus/cursor back to the title input
Fixed - Lost focus after generating a title. Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: dkotter <dkotter@git.wordpress.org>
What?
Part of : #589
Why?
How?
Use of AI Tools
Testing Instructions
Screenshots or screencast
Screen.Recording.2026-06-02.at.2.22.28.PM.mov
Changelog Entry