150: Support more cpu architectures#184

dakale · 2019-11-07T18:16:47Z

For: https://github.com/github/pe-actions-runtime/issues/150

Adds a ~~win-x86~~, linux-arm, and linux-arm64 build

Alpine-based node external is currently not built for arm or arm64

TingluoHuang · 2019-11-07T18:53:04Z

 fi

+if [[ "$PACKAGERUNTIME" == "linux-arm64" ]]; then
+    acquireExternalTool "$NODE_URL/v${NODE12_VERSION}/node-v${NODE12_VERSION}-linux-armv64.tar.gz" node12 fix_nested_dir


also need to build node.js for alpine ARM i think.

👍 Agree, its in progress

Fix arm64 node externals url

TingluoHuang · 2019-11-07T20:58:32Z

    strategy:
      matrix:
-        os: [ubuntu-latest, windows-latest, macOS-latest]
+        runtime: [ linux-x64, linux-arm64, linux-arm, win-x64, win-x86, osx-x64, rhel.6-x64 ]


hope we can kill redhat 6 for now. :D it make the runner download page looks odd...

win x64/x86
linux x64/arm32/arm64
mac x64
redhat6....

Dropped rhel from the build, still need to clean up some spots where rhel.6 is referenced

RedHat 6 is just its own beast, haha!

TingluoHuang · 2019-11-08T01:09:39Z

@dakale you mind want to take the C# file change i made in my branch which fix a bug for ARM64 runner.
users/tihuang/arm64

dakale · 2019-11-11T16:09:37Z

Note: Need to update docs per #162

Dont release x86 until we have an e2e test machine

dakale · 2019-11-11T20:24:51Z

i would suggest these are features. :D
need to double check whether we really need win-x86, since we need to setup extra machines to do E2E validation...

win-x86 temporarily commented out of build/release. We can set this up later since arm is higher priority

…for arm package

bryanmacfarlane · 2019-11-11T22:02:53Z

Yes, we are starting with ARM

Conflicts: releaseNote.md src/runnerversion

thboop · 2019-11-12T18:07:15Z

Really great work 🥇 , there are a few other notes we should add in the release notes

thboop · 2019-11-12T20:22:48Z

+        esac
+    fi
+
+    if [ -e /etc/redhat-release ]; then


we can drop this as its redhat 6 related correct?

Yea.. theres several things that need to be cleaned up. Balancing being lazy/trying to keep this pr simple, but I think it makes sense to just go ahead and clean out the rhel6 stuff

Agreed, we should wait re-adding Red Hat 6 support until there's significant customer demand. Red Hat 6 is considerably harder to give technical support than the other runners due to dependencies being very out of date, which result in a more complex and error-prone setup experience.

We will likely never need a redhat drop since go / node will just work for the linux distro

thboop · 2019-11-12T20:25:46Z

    # Upload agent package zip as build artifact
    - task: PublishBuildArtifacts@1
-      displayName: Publish Artifact (Linux)    
+      displayName: Publish Artifact (Linux)


Publish Artifact (Linux-arm64)

Might be a little clearer

thboop · 2019-11-12T20:26:03Z

+
+    # Upload agent package zip as build artifact
+    - task: PublishBuildArtifacts@1
+      displayName: Publish Artifact (Linux)


Publish Artifact (Linux-arm) may be a little clearer

thboop

Minor thoughts on code cleanup but it looks good

bryanmacfarlane · 2019-11-13T12:28:08Z

It's a bit awkward to update the release notes announcing the availability of ARM when the feature work for ARM isn't done. Still needs UX and setup-* action reaction work. I think it will just lead to a bunch of questions (if and when open sourced) instead of being helpful.

thejoebourneidentity · 2019-11-13T15:05:14Z

@cdb is working on the 'add runner' modal UX now. Not sure about the setup-* work to make them all work.

thboop · 2019-11-13T15:34:58Z

It's a bit awkward to update the release notes announcing the availability of ARM when the feature work for ARM isn't done. Still needs UX and setup-* action reaction work. I think it will just lead to a bunch of questions (if and when open sourced) instead of being helpful.

We can update the release notes to indicate ARM and ARM64 are not production ready or alpha or simply just remove the download information, it should address a majority of the confusion.

…runner-arch

* Cross compile for win-x86, linux-arm, linux-arm64 * Build with actions instead * Remove win-x86 * Preserve CURRENT_PLATFORM in dev.sh * build.yaml * Fix formatting. Remove piplines * Use 4 space indent consistently * x32 -> x86 * TEMP: Only test when platform === target runtime Fix arm64 node externals url * win-x86 externals * Temporarily bench rhel * Add RHEL6, skip L0 on arm for now * Add stub for downloading new node externals when they are ready * Remove RHEL6 * Package based on new runtime names * Remove unused rhel from matrix includes * Update release, add packages * RID typo * Cant cross test arm on x64 hosts * New arch is a feature Dont release x86 until we have an e2e test machine * Fix version * Get version from file to avoid exec error during package on x64 host for arm package * Update Release Notes for 2.161.0 (actions#195) * More cleanup * Update release notes

David Kale added 4 commits November 7, 2019 13:04

Cross compile for win-x86, linux-arm, linux-arm64

bdafe16

Build with actions instead

f6a4f58

Remove win-x86

2f3f51b

Preserve CURRENT_PLATFORM in dev.sh

39b4472

TingluoHuang reviewed Nov 7, 2019

View reviewed changes

Comment thread azure-pipelines.yml Outdated

TingluoHuang reviewed Nov 7, 2019

View reviewed changes

David Kale added 8 commits November 7, 2019 14:20

build.yaml

724f8fc

Fix formatting. Remove piplines

f1b36bb

Use 4 space indent consistently

4899d85

x32 -> x86

5b011dc

TEMP: Only test when platform === target runtime

55948e4

Fix arm64 node externals url

win-x86 externals

9889c42

Temporarily bench rhel

e0f8313

Add RHEL6, skip L0 on arm for now

f4adf75

TingluoHuang reviewed Nov 7, 2019

View reviewed changes

David Kale added 2 commits November 8, 2019 13:30

Add stub for downloading new node externals when they are ready

84b352c

Remove RHEL6

dbf3663

dakale marked this pull request as ready for review November 8, 2019 21:53

dakale changed the title ~~150 runner arch [WIP]~~ 150: Support more cpu architectures Nov 8, 2019

David Kale added 2 commits November 8, 2019 17:13

Package based on new runtime names

7d30e27

Remove unused rhel from matrix includes

dd804e1

dakale requested review from juliobbv and thboop November 11, 2019 16:10

David Kale added 3 commits November 11, 2019 13:07

Update release, add packages

e962329

RID typo

9573fa7

Cant cross test arm on x64 hosts

d46e92e

thboop reviewed Nov 11, 2019

View reviewed changes

Comment thread src/runnerversion Outdated

thboop reviewed Nov 11, 2019

View reviewed changes

Comment thread src/Misc/externals.sh

thboop reviewed Nov 11, 2019

View reviewed changes

Comment thread azure-pipelines-release.yml Outdated

David Kale added 2 commits November 11, 2019 15:02

New arch is a feature

215f788

Dont release x86 until we have an e2e test machine

Fix version

d6956ba

Get version from file to avoid exec error during package on x64 host …

c0e866f

…for arm package

thboop reviewed Nov 11, 2019

View reviewed changes

Comment thread azure-pipelines-release.yml Outdated

Merge branch 'master' into 150-runner-arch

3ade842

Conflicts: releaseNote.md src/runnerversion

Update Release Notes for 2.161.0 (#195)

5d91365

thboop reviewed Nov 12, 2019

View reviewed changes

thboop approved these changes Nov 12, 2019

View reviewed changes

juliobbv approved these changes Nov 13, 2019

View reviewed changes

David Kale added 3 commits November 13, 2019 11:05

More cleanup

72a7bf7

Merge branch '150-runner-arch' of github.com:actions/runner into 150-…

8fb00b1

…runner-arch

Update release notes

a7a9289

dakale merged commit 45c19eb into master Nov 13, 2019

dakale deleted the 150-runner-arch branch November 13, 2019 16:26

kryptonite303 mentioned this pull request Jan 21, 2020

Support for PowerPC and Z series CPU architectures #296

Closed

Conversation

dakale commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TingluoHuang commented Nov 8, 2019

Uh oh!

dakale commented Nov 11, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dakale commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bryanmacfarlane commented Nov 11, 2019

Uh oh!

thboop commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliobbv Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thboop left a comment

Choose a reason for hiding this comment

Uh oh!

bryanmacfarlane commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thejoebourneidentity commented Nov 13, 2019

Uh oh!

thboop commented Nov 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dakale commented Nov 7, 2019 •

edited

Loading

dakale commented Nov 11, 2019 •

edited

Loading

thboop commented Nov 12, 2019 •

edited

Loading

juliobbv Nov 13, 2019 •

edited

Loading

bryanmacfarlane commented Nov 13, 2019 •

edited

Loading