Skip to content

Remove redundant format fields (accepts_3p_tags, category, is_standard)#107

Merged
bokelley merged 1 commit into
mainfrom
bokelley/remove-3p-tags
Oct 14, 2025
Merged

Remove redundant format fields (accepts_3p_tags, category, is_standard)#107
bokelley merged 1 commit into
mainfrom
bokelley/remove-3p-tags

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

Removed three redundant fields from the AdCP format schema that were carrying information already expressed through other means.

Fields Removed

1. accepts_3p_tags

Why: Redundant with HTML/JavaScript asset types

  • Third-party tags ARE HTML/JavaScript assets
  • To find tag-compatible formats, filter by asset_types: ["html"] or ["javascript"]
  • No need for separate boolean flag

2. category

Why: Redundant with format source location

  • Standard formats are defined in /schemas/v1/standard-formats/ directory
  • Custom formats have agent_url pointing to a custom creative agent
  • Format location already indicates whether it's standard or custom

3. is_standard

Why: Same rationale as category - redundant with source location

Changes Made

  • ✅ Updated core format schema (format.json)
  • ✅ Updated 15 standard format schemas
  • ✅ Removed fields from all documentation examples
  • ✅ Added migration guide to CLAUDE.md
  • ✅ All tests passing

Migration

For consumers of the API:

  • Instead of checking accepts_3p_tags, filter by asset_types: ["html"] or ["javascript"]
  • Instead of checking is_standard or category, check format source:
    • Standard formats come from reference creative agent or /standard-formats/ path
    • Custom formats have agent_url pointing to custom agents

Impact

  • Breaking: Only if code explicitly checks these fields
  • Benefit: Cleaner schema, less redundancy, easier maintenance
  • Lines removed: 175 lines of redundant field definitions

🤖 Generated with Claude Code

Removed three redundant fields from the format schema:

1. accepts_3p_tags - Redundant with HTML/JavaScript asset types
   - Third-party tags ARE HTML/JavaScript assets
   - Filter by asset_types: ["html"] or ["javascript"] instead

2. category - Redundant with format source location
   - Standard formats are in /schemas/v1/standard-formats/
   - Custom formats have agent_url pointing to custom agent

3. is_standard - Redundant with format source location
   - Same rationale as category field

Changes:
- Updated core format schema (format.json)
- Updated 15 standard format schemas
- Removed fields from documentation examples
- Added migration guide to CLAUDE.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@bokelley bokelley merged commit fb28649 into main Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant