Add append_n method to FixedSizeBinaryDictionaryBuilder#8498
Merged
Conversation
albertlockett
changed the title
albertlockett
changed the title
append_n method to FixedSizeBinaryDictionaryBuilder
mbrobbel
approved these changes
Sep 29, 2025
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
alamb
approved these changes
Sep 30, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @albertlockett and @mbrobbel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
append_nmethod toFixedSizeBinaryDictionaryBuilder#8497Rationale for this change
Adds a helpful method for the same value multiple times, which also avoids multiple key lookups which could be a slight performance win.
What changes are included in this PR?
Adds the helpful
append_nmethod toFixedSizeBinaryDictionaryBuilder.Are these changes tested?
Yes, I added unit tests covering the changes
Are there any user-facing changes?
Yes, the new method is public