Skip to content

[8910]Fixed doc test with feature prettyprint#8911

Merged
alamb merged 1 commit into
apache:mainfrom
manishkr:8910-arrow-cast-with-prettyprint
Nov 23, 2025
Merged

[8910]Fixed doc test with feature prettyprint#8911
alamb merged 1 commit into
apache:mainfrom
manishkr:8910-arrow-cast-with-prettyprint

Conversation

@manishkr
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.

Rationale for this change

To fix the doc-test with feature-flag prettyprint

What changes are included in this PR?

Enabled feature-flag prettyprint for specific doc-test that need this feature.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 23, 2025
@Jefffrey
Copy link
Copy Markdown
Contributor

Is there a way to do it so it doesn't show up in the doc like this?

image

@manishkr
Copy link
Copy Markdown
Contributor Author

Is there a way to do it so it doesn't show up in the doc like this?

image

I am not aware of any such method, but I think showing it clearly in doc may help the user, it shows caller need to use with enabling prettyprint feature flag.

@Jefffrey
Copy link
Copy Markdown
Contributor

The documentation above it already mentions need for prettyprint feature so it should cover that point.

Perhaps we can try something like this? https://users.rust-lang.org/t/how-to-enable-a-feature-flag-in-a-doc-test/116563/2

@manishkr manishkr force-pushed the 8910-arrow-cast-with-prettyprint branch from 2e21d79 to 49aa18b Compare November 23, 2025 11:46
@manishkr
Copy link
Copy Markdown
Contributor Author

The documentation above it already mentions need for prettyprint feature so it should cover that point.

Perhaps we can try something like this? https://users.rust-lang.org/t/how-to-enable-a-feature-flag-in-a-doc-test/116563/2

Thanks for suggestion, pushed changes with fix.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Nov 23, 2025

I ran cargo test -p arrow-cast locally and it passes for me now on this branch ❤️

Thanks @manishkr and @Jefffrey

@alamb alamb merged commit af7a07c into apache:main Nov 23, 2025
26 checks passed
@manishkr manishkr deleted the 8910-arrow-cast-with-prettyprint branch November 24, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo test -p arrow-cast fails on main

3 participants