Remove unnecessary Arc<ArrayRef>#9316
Merged
Merged
Conversation
github-actions
Bot
added
parquet
Jefffrey
approved these changes
Feb 2, 2026
alamb
approved these changes
Feb 2, 2026
| DataType::Dictionary(_, _) => { | ||
| let array = array.as_any_dictionary(); | ||
| let values = date_part(array.values(), part)?; | ||
| let values = Arc::new(values) as ArrayRef; |
Contributor
Author
|
Note: This PR is really just fixing the examples I found so far. I suspect I found them all (by removing the |
Contributor
Author
|
@alamb -- something seems to have gone wrong with CI -- one job failed to acquire an instance to run on, and after 15 minutes everything canceled. Is that normal? |
Contributor
|
Close/reopen to retrigger CI |
Contributor
Author
|
Same thing again...
|
Contributor
Appears to be github related |
Contributor
|
Woohoo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Because
Arc<dyn Array>(ArrayRef) implementsArray, it's easy to create redundantArc<Arc<dyn Array>>. The extra indirection is pure overhead (both cognitive and runtime) with no benefit.What changes are included in this PR?
Remove the redundant wrapping.
Are these changes tested?
Compilation suffices -- failing to wrap a concrete array type in Arc would cause compilation failures.
Are there any user-facing changes?
No.