[Variant] Add variant_to_arrow Struct type support#9572
Merged
Conversation
variant_to_arrow Struct type supportvariant_to_arrow Struct type support
Contributor
Author
|
@klion26 @codephage2020 @scovich bothering you again... 😄 |
scovich
approved these changes
Mar 18, 2026
Co-authored-by: Ryan Johnson <scovich@users.noreply.github.com>
Co-authored-by: Ryan Johnson <scovich@users.noreply.github.com>
Contributor
Author
|
@scovich I've addressed the nits, thanks for the review! |
klion26
approved these changes
Mar 19, 2026
Member
klion26
left a comment
There was a problem hiding this comment.
LGMT, thanks for the contribution.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_to_arrowStructtype support #9529 .Rationale for this change
variant_getTODO:arrow-rs/parquet-variant-compute/src/variant_get.rs
Lines 89 to 92 in 3b61796
shred_basic_variantWhat changes are included in this PR?
StructVariantToArrowRowBuilderbuilder.make_variant_to_arrow_row_builderlogic tomake_typed_variant_to_arrow_row_builderto reuse byStructarray's inner fields.variant_gettest to show that it now handles unshreddedStructVariantArrayAre these changes tested?
test_struct_row_builder_handles_unshredded_nested_structsAre there any user-facing changes?
No