[Variant] Add unshredded Struct fast-path for variant_get(..., Struct)#9597
Merged
Conversation
sdf-jkl
force-pushed
the
variant_get-unshredded-struct
branch
from
49c344b to
c783026
Compare
github-actions
Bot
added
parquet
sdf-jkl
force-pushed
the
variant_get-unshredded-struct
branch
from
c783026 to
7f16038
Compare
Contributor
Author
|
@scovich @klion26 @codephage2020 please take a look when available. |
klion26
approved these changes
Mar 23, 2026
klion26
left a comment
klion26
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the contribution.
Contributor
Author
|
@scovich can we merge? |
Contributor
|
Let's do it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Structfast-path forvariant_get(..., Struct)#9596.Rationale for this change
Check issue
What changes are included in this PR?
Reuse
shred_basic_variantas a fast path for unshreddedStructhandling invariant_get(..., Struct)Are these changes tested?
Yes, added two unit tests to establish safe mode behavior.
Are there any user-facing changes?