Support GenericListViewArray::new_unchecked and refactor ListView json decoder#9648
Merged
alamb merged 3 commits intoApr 15, 2026
Merged
Conversation
liamzwbao
changed the title
GenericListViewArray::new_unchecked and refactor ListView json decoder
liamzwbao
changed the title
GenericListViewArray::new_unchecked and refactor ListView json decoderGenericListViewArray::new_unchecked and refactor ListView json decoder
liamzwbao
force-pushed
the
issue-9646-unsafe-list-view-json-reader
branch
from
3b662b4 to
519efa9
Compare
liamzwbao
force-pushed
the
issue-9646-unsafe-list-view-json-reader
branch
from
519efa9 to
5a9d088
Compare
alamb
approved these changes
Apr 14, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great to me -- thank you @liamzwbao
I left a small suggestion on comments, but I don't think it is necessary
| /// | ||
| /// # Safety | ||
| /// | ||
| /// Safe if [`Self::new`] would not panic with the given arguments |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Safe if [`Self::new`] would not panic with the given arguments | |
| /// The parts must be a valid ListViewArray according to the Arrow spec. | |
| /// See [`Self::try_new`] for details |
Contributor
|
Thank you @liamzwbao |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
… json decoder (apache#9648) # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#9646. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Support `GenericListViewArray::new_unchecked` and refactor ListView json decoder. Stacked on apache#9497, benchmark added in apache#9647 # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Covered by existing tests # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GenericListViewArray::new_uncheckedand refactor ListView json decoder #9646.Rationale for this change
What changes are included in this PR?
Support
GenericListViewArray::new_uncheckedand refactor ListView json decoder. Stacked on #9497, benchmark added in #9647Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No