[Variant] variant_get should follow JSONPath semantics for Field path element#9676
Merged
Conversation
Contributor
Author
|
@scovich @klion26 @codephage2020 please take a look when available! |
codephage2020
left a comment
codephage2020
left a comment
Contributor
There was a problem hiding this comment.
LGTM! One small nit:
klion26
approved these changes
Apr 10, 2026
klion26
left a comment
klion26
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the contribution.
| shredding_state: &BorrowedShreddingState<'a>, | ||
| path_element: &VariantPathElement<'_>, | ||
| cast_options: &CastOptions, | ||
| _cast_options: &CastOptions, |
Member
There was a problem hiding this comment.
Do we still want to keep it if it doesn't needed
Contributor
Author
There was a problem hiding this comment.
If this PR goes first, the next variant_get PR will return it.
Contributor
|
🎉 |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
…th element (apache#9676) # Which issue does this PR close? Currently this is the only place in `main` that handles `Path` in `variant_get`. Other `variant_get` related PRs already follow the JSONPath sementics. (apache#9598 and apache#8354) - Closes apache#9606. # Rationale for this change Check issue # What changes are included in this PR? - Changed `variant_get` field path handling when can't cast to Struct - Updated the related unit test to check the new logic - Cleaned up some nearby tests # Are these changes tested? Yes, unit tests # Are there any user-facing changes? Yes, behavior change for `variant_get` kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Currently this is the only place in
mainthat handlesPathinvariant_get. Othervariant_getrelated PRs already follow the JSONPath sementics. (#9598 and #8354)Rationale for this change
Check issue
What changes are included in this PR?
variant_getfield path handling when can't cast to StructAre these changes tested?
Yes, unit tests
Are there any user-facing changes?
Yes, behavior change for
variant_getkernel