fix(arrow-cast): fix incorrect conversion#9852
Merged
Merged
Conversation
MICROSECONDS / NANOSECONDS = 0, this should be NANOSECONDS / MILLISECONDS. Found with claude code audit.
Jefffrey
approved these changes
Apr 30, 2026
Contributor
|
Thanks @bboissin |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
MICROSECONDS / NANOSECONDS = 0, this should be NANOSECONDS / MILLISECONDS. Found with claude code audit. # Which issue does this PR close? - Closes apache#9851 # Rationale for this change Bugfix, instead of multiplying by 0 we multiply by the correct factor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MICROSECONDS / NANOSECONDS = 0, this should be NANOSECONDS / MILLISECONDS.
Found with claude code audit.
Which issue does this PR close?
Rationale for this change
Bugfix, instead of multiplying by 0 we multiply by the correct factor.