[arrow-array] Use consistent value_length name in FixedSizeBinaryArray#9905
Merged
Conversation
alamb
force-pushed
the
alamb/rename_fsb
branch
2 times, most recently
from
ed2ff20 to
633b5c4
Compare
alamb
changed the title
value_length name in FixedSizeBinaryArray
alamb
commented
May 5, 2026
| data_type, | ||
| value_data: values, | ||
| value_length: size, | ||
| value_length, |
Contributor
Author
There was a problem hiding this comment.
here is an example of inconsistent terminology size and value_length used for the same concept
After this PR, the same concept has the same name in both parameters and fields
Contributor
Author
|
Since this is a name only hange and I have some stacked work on it, I will merge it in |
Contributor
Author
|
Thank you @etseidl |
Rich-T-kid
pushed a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Jun 2, 2026
…ray (apache#9905) # Which issue does this PR close? - Part of apache#9906 - First follow on to apache#9872 # Rationale for this change While trying to avoid overflows due to using i32 arithmetic in FixedSizeBinaryArray, I found the use of the term `size` in parameters to be confusing when the field name is called `value_length` # What changes are included in this PR? Change several parameter / variable names to `value_length` to keep the code consistent # Are these changes tested? By CI # Are there any user-facing changes? No this is an internal code refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FixedSizeBinaryArrays #9906FixedSizeBinaryArrayi32offset overflows (try 2) #9872Rationale for this change
While trying to avoid overflows due to using i32 arithmetic in FixedSizeBinaryArray, I found the use of the term
sizein parameters to be confusing when the field name is calledvalue_lengthWhat changes are included in this PR?
Change several parameter / variable names to
value_lengthto keep the code consistentAre these changes tested?
By CI
Are there any user-facing changes?
No this is an internal code refactor