Implement EXTRACT expression with week, month, day, hour#1974
Conversation
|
@alamb @liukun4515 PTAL |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @Ted-Jiang and @jimexist
| ); | ||
| test_expression!("date_part('WEEK', CAST('2003-01-01' AS DATE))", "1"); | ||
|
|
||
| //TODO Creating logical plan for 'SELECT EXTRACT(WEEK FROM to_timestamp('2020-09-08T12:00:00+00:00'))' |
There was a problem hiding this comment.
Many keywords got added in apache/datafusion-sqlparser-rs#427 from @mobuchowski (👋 ) but sadly it seems to be missing week 😭
There was a problem hiding this comment.
I didn't meant to make you feel bad @mobuchowski -- mostly I was trying to give you props for adding stuff to sqlparser ;)
There was a problem hiding this comment.
Don't worry, that's not how I received it 🙂
There was a problem hiding this comment.
@Ted-Jiang Maybe you can file a pr to fix this.
There was a problem hiding this comment.
@liukun4515 @liukun4515 @mobuchowski i would like to add this , it's a good chance to start familiar sqlparser
😊
There was a problem hiding this comment.
|
Sorry for the later response. |
|
Thanks @Ted-Jiang -- I hope to spend some non trivial amount of time this weekend reviewing and merging PRs |
5 participants
Which issue does this PR close?
Closes #1896.
Rationale for this change
Already add compute method in
arrow-rsPR.But found
will fix
EXTRACT(WEEK FROM to_timestamp('2020-09-08T12:00:00+00:00'))insqlparserWhat changes are included in this PR?
Are there any user-facing changes?