Skip to content

[server] feat: support alter table properties#1625

Merged
luoyuxia merged 12 commits into
apache:mainfrom
gyang94:issue-100-table-changes
Sep 24, 2025
Merged

[server] feat: support alter table properties#1625
luoyuxia merged 12 commits into
apache:mainfrom
gyang94:issue-100-table-changes

Conversation

@gyang94
Copy link
Copy Markdown
Contributor

@gyang94 gyang94 commented Aug 30, 2025

Purpose

Linked issue: close #100
Support alter table properties and custom properties

Brief change log

Tests

API and Format

Documentation

@gyang94 gyang94 force-pushed the issue-100-table-changes branch 2 times, most recently from 38df8df to d940289 Compare August 30, 2025 15:45
@polyzos polyzos force-pushed the main branch 3 times, most recently from d88c76c to 434a4f4 Compare August 31, 2025 15:13
@LiebingYu
Copy link
Copy Markdown
Contributor

I suggest use TableChange instead of FlussTableChange. After all, we are always in Fluss.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements support for altering table properties in the Fluss system. It introduces functionality to modify table configurations and custom properties through ALTER TABLE operations.

  • Adds new API endpoints and message structures for alter table operations
  • Implements table property validation and change processing logic
  • Provides client-side and Flink catalog integration for alter table functionality

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
fluss-rpc/src/main/proto/FlussApi.proto Defines new protobuf messages for alter table configs request/response
fluss-rpc/src/main/java/org/apache/fluss/rpc/protocol/ApiKeys.java Adds ALTER_TABLE API key enum
fluss-rpc/src/main/java/org/apache/fluss/rpc/gateway/AdminGateway.java Adds alterTable method to admin gateway interface
fluss-common/src/main/java/org/apache/fluss/metadata/*.java Core metadata classes for table changes and alter operation types
fluss-common/src/main/java/org/apache/fluss/config/FlussConfigUtils.java Adds alterable config lists for table and client options
fluss-server/src/main/java/org/apache/fluss/server/coordinator/*.java Server-side implementation of alter table logic
fluss-server/src/main/java/org/apache/fluss/server/utils/*.java Utility classes for validation and message conversion
fluss-client/src/main/java/org/apache/fluss/client/admin/*.java Client-side admin API implementation
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/*.java Flink catalog integration for alter table operations
test files Various test files adding alter table functionality tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread fluss-rpc/src/main/proto/FlussApi.proto
@gyang94 gyang94 force-pushed the issue-100-table-changes branch from 06be0e9 to f486eb2 Compare September 23, 2025 07:32
Copy link
Copy Markdown
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyang94 Thanks for the pr. Left some comments. PTAL. Also, don't forget to rebase main branch which make test stable.

Comment thread fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java Outdated
Comment thread fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java Outdated
Comment thread fluss-common/src/main/java/org/apache/fluss/metadata/AlterTableConfigsOpType.java Outdated
Comment thread fluss-common/src/main/java/org/apache/fluss/metadata/AlterTableConfigsOpType.java Outdated
Comment thread fluss-common/src/main/java/org/apache/fluss/metadata/AlterTableConfigsOpType.java Outdated
Comment thread fluss-rpc/src/main/proto/FlussApi.proto Outdated
@gyang94 gyang94 force-pushed the issue-100-table-changes branch 2 times, most recently from 74dfd08 to 961900c Compare September 23, 2025 09:28
@gyang94 gyang94 force-pushed the issue-100-table-changes branch from 961900c to bf4cf10 Compare September 23, 2025 09:37
@luoyuxia luoyuxia requested a review from Copilot September 24, 2025 03:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@luoyuxia luoyuxia force-pushed the issue-100-table-changes branch from 45c25c8 to 76ac839 Compare September 24, 2025 03:41
Copy link
Copy Markdown
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luoyuxia
Copy link
Copy Markdown
Contributor

@gyang94 I'm going to merge this pr. If you have further comments, you can fix it when you develop in #431

@luoyuxia luoyuxia merged commit 9df7b72 into apache:main Sep 24, 2025
5 checks passed
leosanqing pushed a commit to leosanqing/fluss that referenced this pull request Sep 29, 2025
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support alter table to update properties and custom properties

5 participants