[Flink] Increase code coverage for flinkCatalogOptions#929
Merged
Conversation
Contributor
Author
|
@wuchong, please help me with the review, whenever you get a chance, meanwhile I will get started with |
MehulBatra
changed the title
MehulBatra
changed the title
2 tasks
wuchong
reviewed
Jun 7, 2025
MehulBatra
force-pushed
the
flink-catalog-options-coverage
branch
from
c20265b to
5ddc9ea
Compare
wuchong
reviewed
Jun 12, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Remove the entry com.alibaba.fluss.flink.catalog.FlinkCatalogOptions in fluss-test-coverage pom?
wuchong
approved these changes
Jun 13, 2025
Contributor
Author
|
Thank you @wuchong for the review! |
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
polyzos
pushed a commit
to polyzos/fluss
that referenced
this pull request
Aug 30, 2025
polyzos
pushed a commit
to HZY-Wade/fluss
that referenced
this pull request
Aug 31, 2025
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #928
Enhance FlinkCatalogOptions Javadoc & FlinkCatalogFactory with unit tests to improve test coverage.
Brief change log
Tests
Added
FlinkCatalogFactorywith the following test cases:testOptionalOptionsConfiguration: Testing the optional options configuration of the factoryAPI and Format
None
Documentation
None