MINOR: use classic consumer with ZK mode for DeleteOffsetsConsumerGroupCommandIntegrationTest#15872
Merged
Conversation
Member
|
Maybe we should merge |
chia7712
reviewed
May 6, 2024
| @ClusterTest | ||
| @ClusterTemplate("generator") | ||
| public void testDeleteOffsetsOfStableConsumerGroupWithTopicPartition() { | ||
| for (Map<String, Object> consumerConfig: consumerConfigs) { |
Member
There was a problem hiding this comment.
consumerConfigs need to be rewritten by ClusterInstance#supportedGroupProtocols
see https://github.com/apache/kafka/pull/15766/files#r1590222192
Member
Author
There was a problem hiding this comment.
Updated it. Thanks.
FrankYang0529
force-pushed
the
minor-use-zk-with-classic-consumer-for-DeleteOffsetsConsumerGroupCommandIntegrationTest
branch
from
4bd4005 to
c8a2e3f
Compare
chia7712
reviewed
May 8, 2024
|
|
||
| @ClusterTest | ||
| private static void generator(ClusterGenerator clusterGenerator) { | ||
| Map<String, String> serverProperties = new HashMap<>(); |
Member
There was a problem hiding this comment.
Please use ConsumerGroupCommandTestUtils#generator
Member
Author
There was a problem hiding this comment.
Updated it. Thanks.
…upCommandIntegrationTest Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
minor-use-zk-with-classic-consumer-for-DeleteOffsetsConsumerGroupCommandIntegrationTest
branch
from
c8a2e3f to
68ebedb
Compare
FrankYang0529
deleted the
minor-use-zk-with-classic-consumer-for-DeleteOffsetsConsumerGroupCommandIntegrationTest
branch
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 9, 2024
…upCommandIntegrationTest (apache#15872) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…upCommandIntegrationTest (apache#15872) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #15766 (comment)
Add ZK mode with classic consumer back to DeleteOffsetsConsumerGroupCommandIntegrationTest.
Committer Checklist (excluded from commit message)