Skip to content

Trim threadConfiguration to accept input surrounded with spaces#12042

Merged
slawekjaranowski merged 1 commit into
apache:maven-3.9.xfrom
slawekjaranowski:cp-11851
May 13, 2026
Merged

Trim threadConfiguration to accept input surrounded with spaces#12042
slawekjaranowski merged 1 commit into
apache:maven-3.9.xfrom
slawekjaranowski:cp-11851

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

  • Test that c (lower case) in Nc is not recognized as hexdigit
  • Test parsing threads from 1C input
  • Test parsing threads from 1C input
  • Trim threadConfiguration to accept input like 1C
  • Test parsing threads from 1 and 1 input
  • Use trimmed input also for whole numbers

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

* Test that `c` (lower case) in `Nc` is not recognized as hexdigit
* Test parsing threads from ` 1C` input
* Test parsing threads from ` 1C ` input
* Trim `threadConfiguration` to accept input like ` 1C `
* Test parsing threads from ` 1` and ` 1 ` input
* Use trimmed input also for whole numbers

---------

Co-authored-by: Piotrek Żygieło <pzygielo@users.noreply.github.com>
@slawekjaranowski slawekjaranowski added this to the 3.9.16 milestone May 12, 2026
@slawekjaranowski slawekjaranowski self-assigned this May 12, 2026
@slawekjaranowski slawekjaranowski requested a review from cstamas May 12, 2026 20:12
@slawekjaranowski
Copy link
Copy Markdown
Member Author

@pzygielo FYI

@slawekjaranowski slawekjaranowski merged commit 229e9d7 into apache:maven-3.9.x May 13, 2026
18 checks passed
dongjoon-hyun added a commit to apache/spark that referenced this pull request May 21, 2026
### What changes were proposed in this pull request?

This PR upgrades `Maven` to 3.9.16 for Apache Spark 5.0.0.

### Why are the changes needed?

To use the latest Maven version.
> Regression fixes and other improvements from Maven 3.9.15. All users already on Maven 3.9.x are advised to upgrade.

- https://maven.apache.org/docs/3.9.16/release-notes.html
  - apache/maven#12042
  - apache/maven#12022
- https://github.com/apache/maven/releases/tag/maven-3.9.16

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and check the log.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code (claude-opus-4-7)

Closes #56048 from dongjoon-hyun/SPARK-56997.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@slawekjaranowski slawekjaranowski deleted the cp-11851 branch May 25, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow argument to --threads to be surrounded by spaces

4 participants