Trim threadConfiguration to accept input surrounded with spaces#12042
Merged
Conversation
* Test that `c` (lower case) in `Nc` is not recognized as hexdigit * Test parsing threads from ` 1C` input * Test parsing threads from ` 1C ` input * Trim `threadConfiguration` to accept input like ` 1C ` * Test parsing threads from ` 1` and ` 1 ` input * Use trimmed input also for whole numbers --------- Co-authored-by: Piotrek Żygieło <pzygielo@users.noreply.github.com>
Member
Author
|
@pzygielo FYI |
1 task
cstamas
approved these changes
May 13, 2026
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
May 21, 2026
### What changes were proposed in this pull request? This PR upgrades `Maven` to 3.9.16 for Apache Spark 5.0.0. ### Why are the changes needed? To use the latest Maven version. > Regression fixes and other improvements from Maven 3.9.15. All users already on Maven 3.9.x are advised to upgrade. - https://maven.apache.org/docs/3.9.16/release-notes.html - apache/maven#12042 - apache/maven#12022 - https://github.com/apache/maven/releases/tag/maven-3.9.16 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and check the log. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-7) Closes #56048 from dongjoon-hyun/SPARK-56997. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
rox-b8
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c(lower case) inNcis not recognized as hexdigit1Cinput1CinputthreadConfigurationto accept input like1C1and1inputFollowing this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.