Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1#18890

Merged
szha merged 1 commit intoapache:v1.xfrom
stu1130:v1.x
Aug 14, 2020
Merged

[v1.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1#18890
szha merged 1 commit intoapache:v1.xfrom
stu1130:v1.x

Conversation

@stu1130
Copy link
Contributor

@stu1130 stu1130 commented Aug 10, 2020 •
edited
Loading

[v1.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

@bgawrych @pengzhao-intel

@mxnet-bot
Copy link

mxnet-bot commented Aug 10, 2020

Hey @stu1130 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-gpu, clang, windows-cpu, website, edge, miscellaneous, sanity, unix-cpu, unix-gpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky requested a review from wkcn August 10, 2020 18:48
@samskalicky samskalicky mentioned this pull request Aug 10, 2020
Open
wkcn
wkcn approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Aug 12, 2020

@stu1130 could you take a look for CI and we can merge it soon?

@stu1130 @wkcn
[v1.7.x] backport Invoke mkldnn and cudnn BatchNorm when axis != 1 t…
6bd508e 
…o v1.7.x (apache#18676)

* [Improvement] Invoke mkldnn and cudnn BatchNorm when axis != 1 (apache#18504)

* fix batch norm when fix_gamma is True

* support gradient accumulation for batch norm

* mkldnn batchnorm support grad add

* unittest for bn

* fix bn arg

* fix lint

* fix mkldnn

* fix mkldnn bn

* fix grad when fixing gamma

* fix naive gpu bn

* fix lint

* invoke mkldnn and cudnn batchnorm when axis != 1

* backport 18500

* change condition

* fix

* fix

* add mkldnn_off for bn

* remove mkldnn_off

* recover save_000800.json

* cast

* remove  and fix flaky test

Co-authored-by: JackieWu <wkcn@live.cn>
@stu1130
Copy link
Contributor Author

stu1130 commented Aug 13, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 13, 2020

Jenkins CI successfully triggered : [unix-gpu]

@stu1130
Copy link
Contributor Author

stu1130 commented Aug 13, 2020

@pengzhao-intel the CI passed.

@szha szha merged commit d32ba4f into apache:v1.x Aug 14, 2020
@szha szha added this to the v1.8.0 milestone Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wkcn wkcn wkcn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@stu1130 @mxnet-bot @pengzhao-intel @wkcn @szha