Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backport 'Update CUB and include it only for CUDA < 11 #18799'#18975

Merged
samskalicky merged 2 commits intoapache:v1.xfrom
Kh4L:backport_18799
Sep 15, 2020
Merged

[1.x] Backport 'Update CUB and include it only for CUDA < 11 #18799'#18975
samskalicky merged 2 commits intoapache:v1.xfrom
Kh4L:backport_18799

Conversation

@Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Aug 21, 2020

Description

Backport Update CUB and include it only for CUDA < 11 #18799

@Kh4L Kh4L requested a review from szha as a code owner August 21, 2020 01:57
@mxnet-bot
Copy link

mxnet-bot commented Aug 21, 2020

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, unix-cpu, windows-gpu, centos-gpu, unix-gpu, edge, windows-cpu, website, centos-cpu, miscellaneous, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@fireant
Copy link
Contributor

fireant commented Sep 4, 2020

@Kh4L given the all language bindings/interfaces are broken in the master branch, will this be merged into 1.x/1.7.x? or for some reason this has been canceled? Thank you!

@Kh4L
Copy link
Contributor Author

Kh4L commented Sep 8, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

mxnet-bot commented Sep 8, 2020

Jenkins CI successfully triggered : [unix-gpu, unix-cpu, edge, sanity, windows-gpu, miscellaneous, website, windows-cpu, clang, centos-gpu, centos-cpu]

@samskalicky samskalicky mentioned this pull request Sep 9, 2020
Open
@Kh4L
Update CUB and only for CUDA < 11 apache#18799 and update Makefile
74d1535 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Copy link
Contributor Author

Kh4L commented Sep 14, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

mxnet-bot commented Sep 14, 2020

Jenkins CI successfully triggered : [windows-gpu, centos-cpu, miscellaneous, unix-cpu, unix-gpu, centos-gpu, clang, website, windows-cpu, edge, sanity]

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 14, 2020
@Kh4L
Add preprocessor option to silence CUB C++14 warning
34cc8fc 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review labels Sep 14, 2020
@samskalicky samskalicky merged commit e1bcb33 into apache:v1.x Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@ptrendx ptrendx ptrendx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kh4L @mxnet-bot @fireant @ptrendx @samskalicky @lanking520