This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Conversation
* fix block.export ```net.hybridize``` may optimize out some ops. These ops are alive in nn.Block(also nn.HybridBlock), but its names are not contained in symbol's ```arg_names``` list. So ignore these ops except that their name are end with 'running_mean' or 'running_var'. * Update block.py let user can save their extra param. * add allow_extra add allow_extra to let user decide whether to save extra parameters or not. * Update block.py add moving_mean and moving_var when export model with SymbolBlock * Update python/mxnet/gluon/block.py typo Co-authored-by: Sheng Zha <szha@users.noreply.github.com> * Update block.py * Update block.py * Update python/mxnet/gluon/block.py Co-authored-by: Leonard Lausen <leonard@lausen.nl> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>
|
Hey @jmracek , Thanks for submitting the PR
CI supported jobs: [miscellaneous, website, clang, edge, windows-gpu, windows-cpu, centos-cpu, sanity, unix-gpu, unix-cpu, centos-gpu] Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks commit 5122d32 into the v1.x branch. This is to enable the export of models where dangling layers are optimized out during symbol export. For more information, see here and here.
net.hybridizemay optimize out some ops. These ops are alive in nn.Block(also nn.HybridBlock), but its names are not contained in symbol'sarg_nameslist. So ignore these ops except that their name are end with 'running_mean' or 'running_var'.let user can save their extra param.
add allow_extra to let user decide whether to save extra parameters or not.
add moving_mean and moving_var when export model with SymbolBlock
typo
Co-authored-by: Sheng Zha szha@users.noreply.github.com
Update block.py
Update block.py
Update python/mxnet/gluon/block.py
Co-authored-by: Leonard Lausen leonard@lausen.nl
Co-authored-by: Sheng Zha szha@users.noreply.github.com
Co-authored-by: Leonard Lausen leonard@lausen.nl
Description
(Brief description on what this PR is about)
Checklist
Essentials
Changes
Comments