This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Submodule] Upgrade to oneDNN v1.6.3#19153
Merged
pengzhao-intel merged 6 commits intoapache:masterfrom Sep 16, 2020
Merged
Conversation
|
Hey @TaoLv , Thanks for submitting the PR
CI supported jobs: [sanity, clang, centos-cpu, unix-cpu, unix-gpu, miscellaneous, centos-gpu, windows-gpu, edge, windows-cpu, website] Note: |
Member
Author
|
@pengzhao-intel @anko-intel @leezu Please take a look. Thanks! |
pengzhao-intel
approved these changes
Sep 16, 2020
Contributor
pengzhao-intel
left a comment
pengzhao-intel
left a comment
There was a problem hiding this comment.
LGTM and merging now.
anko-intel
pushed a commit
to anko-intel/incubator-mxnet
that referenced
this pull request
Sep 16, 2020
* upgrade to oneDNN v1.6 release branch * oneDNN v1.6 * fix cpp test * build oneDNN with c++11 * Revert "build oneDNN with c++11" This reverts commit 5365d83. * oneDNN v1.6.3
Contributor
|
I put it to branch v1.x also: #19161 |
Member
Author
Thank you @anko-intel ! |
anko-intel
pushed a commit
to anko-intel/incubator-mxnet
that referenced
this pull request
Sep 17, 2020
* upgrade to oneDNN v1.6 release branch * oneDNN v1.6 * fix cpp test * build oneDNN with c++11 * Revert "build oneDNN with c++11" This reverts commit 5365d83. * oneDNN v1.6.3
pengzhao-intel
pushed a commit
that referenced
this pull request
Sep 18, 2020
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Nov 17, 2020
* upgrade to oneDNN v1.6 release branch * oneDNN v1.6 * fix cpp test * build oneDNN with c++11 * Revert "build oneDNN with c++11" This reverts commit 5365d83. * oneDNN v1.6.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I cannot reopen the original PR #18801, hence a new one.
The compilation issue with GCC 7 should be fixed in the v1.6.3 release per the release note:
https://github.com/oneapi-src/oneDNN/releases/tag/v1.6.3
Checklist
Essentials
Changes
Comments