This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)#19199
Merged
pengzhao-intel merged 1 commit intoapache:v1.xfrom Sep 23, 2020
Merged
[BUGFIX] [v1.x] ElementWiseSum fix for oneDNN (#18777)#19199pengzhao-intel merged 1 commit intoapache:v1.xfrom
pengzhao-intel merged 1 commit intoapache:v1.xfrom
Conversation
* Fix ElementwiseSum for DNNL * Fix sanity and replace push_back with emplace_back * Change order of the data format conditions * Add NOLINT to avoid readability error * Add test for oneDNN ElemwiseSum Co-authored-by: Bart Gawrych <gawrych.bartlomiej@intel.com>
|
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [unix-cpu, website, edge, clang, windows-gpu, miscellaneous, centos-cpu, unix-gpu, windows-cpu, centos-gpu, sanity] Note: |
Contributor
Author
|
@mxnet-bot run ci [website] |
|
Jenkins CI successfully triggered : [website] |
Contributor
Author
pengzhao-intel
approved these changes
Sep 23, 2020
Contributor
pengzhao-intel
left a comment
pengzhao-intel
left a comment
There was a problem hiding this comment.
LGTM and merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #18777
Fix ElementwiseSum for DNNL
Fix sanity and replace push_back with emplace_back
Change order of the data format conditions
Add NOLINT to avoid readability error
Add test for oneDNN ElemwiseSum
Description
(Brief description on what this PR is about)
Checklist
Essentials