Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[wip] onnx support more ops#19653

Merged
Zha0q1 merged 11 commits intoapache:v1.xfrom
Zha0q1:onnx_ops_batch1
Dec 15, 2020
Merged

[wip] onnx support more ops#19653
Zha0q1 merged 11 commits intoapache:v1.xfrom
Zha0q1:onnx_ops_batch1

Conversation

@Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Dec 10, 2020 •
edited
Loading

  • SequenceMask
  • _contrib_interleaved_matmul_selfatt_qk
  • broadcast_axis
  • reshape (add support for reverse)

Test cases to be added after onnx test suite is more complete

@Zha0q1 Zha0q1 requested a review from szha as a code owner December 10, 2020 22:18
@mxnet-bot
Copy link

mxnet-bot commented Dec 10, 2020

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, sanity, website, clang, miscellaneous, centos-gpu, edge, windows-cpu, unix-gpu, unix-cpu, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 10, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 11, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 11, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 12, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@Zha0q1 Zha0q1 closed this Dec 14, 2020
@Zha0q1 Zha0q1 reopened this Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
josephevans
josephevans reviewed Dec 15, 2020
View reviewed changes
python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated
return nodes


def make_tensor(shape_list, shape_name, initializer, dtype='int64'):
Copy link
Contributor

@josephevans josephevans Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to create_tensor() or something, so it's a clear distinction between this and onnx.helper.make_tensor().

Copy link
Contributor Author

@Zha0q1 Zha0q1 Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah noted

python/mxnet/contrib/onnx/mx2onnx/_op_translations.py Outdated

if(axis == 0):
nodes += [
make_node('Reshape', [name+'_slice_0', name+'_void'], [name+'_max_len'], name = '111'),
Copy link
Contributor

@josephevans josephevans Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify the name parameter?

Copy link
Contributor Author

@Zha0q1 Zha0q1 Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh sorry those were leftovers when I was debugging. Will remove in next push

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 15, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
@Zha0q1 Zha0q1 merged commit b3d9af2 into apache:v1.x Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@josephevans josephevans josephevans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zha0q1 @mxnet-bot @josephevans @lanking520