Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add image segmentation end-to-end tests and expand object classification tests#19815

Merged
Zha0q1 merged 4 commits intoapache:v1.xfrom
josephevans:onnx_fixes_round9_v1.x
Feb 2, 2021
Merged

[v1.x] Add image segmentation end-to-end tests and expand object classification tests#19815
Zha0q1 merged 4 commits intoapache:v1.xfrom
josephevans:onnx_fixes_round9_v1.x

Conversation

@josephevans
Copy link
Contributor

@josephevans josephevans commented Feb 2, 2021

Description

Add new image segmentation tests to test suite, and expand object classification tests to test all supported models.

@mxnet-bot
Copy link

mxnet-bot commented Feb 2, 2021

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-gpu, website, unix-gpu, edge, windows-gpu, clang, centos-cpu, unix-cpu, windows-cpu, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 2, 2021
@josephevans
Copy link
Contributor Author

josephevans commented Feb 2, 2021

I added the test images to the incubator-mxnet-ci repo and will update this PR to reflect the new URLs once this is merged: apache/mxnet-ci#35

@Zha0q1
Copy link
Contributor

Zha0q1 commented Feb 2, 2021

I added the test images to the incubator-mxnet-ci repo and will update this PR to reflect the new URLs once this is merged: apache/mxnet-ci#35

Is that pr ready to merge?

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 2, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 2, 2021
Zha0q1
Zha0q1 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

waytrue17
waytrue17 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zha0q1 Zha0q1 merged commit f7b7acc into apache:v1.x Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josephevans @mxnet-bot @Zha0q1 @waytrue17 @lanking520