Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix AmpCast for float16#20003

Merged
szha merged 1 commit intoapache:masterfrom
anko-intel:anko_19631_amp_cast
Mar 12, 2021
Merged

[BUGFIX] Fix AmpCast for float16#20003
szha merged 1 commit intoapache:masterfrom
anko-intel:anko_19631_amp_cast

Conversation

@anko-intel
Copy link
Contributor

@anko-intel anko-intel commented Mar 10, 2021

Forward port #19749 from v1.x to master.

  • Fix AmpCast for float16

OneDNN doesn't support float16 format so fallback to standard
implementation is needed.
It fixes issue #19631.

  • Enable amp_cast test for float16 on CPU context

@anko-intel
[BUGFIX] Fix AmpCast for float16 (apache#19749)
f76d1e3 
* Fix AmpCast for float16

OneDNN doesn't support float16 format so fallback to standard
implementation is needed.
It fixes issue 19631.

* Enable amp_cast test for float16 on CPU context
@mxnet-bot
Copy link

mxnet-bot commented Mar 10, 2021

Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, windows-gpu, unix-cpu, unix-gpu, website, edge, clang, centos-cpu, centos-gpu, windows-cpu, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 10, 2021
@anko-intel
Copy link
Contributor Author

anko-intel commented Mar 11, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu, windows-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Mar 11, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, windows-cpu]

@anko-intel
Copy link
Contributor Author

anko-intel commented Mar 11, 2021

@mxnet-bot run ci [macosx-x86_64, centos-gpu, windows-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Mar 11, 2021

Jenkins CI successfully triggered : [centos-gpu, windows-cpu]

@anko-intel
Copy link
Contributor Author

anko-intel commented Mar 11, 2021

@mxnet-bot run ci [windows-gpu, windows-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Mar 11, 2021

Jenkins CI successfully triggered : [windows-cpu, windows-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 11, 2021
@anko-intel
Copy link
Contributor Author

anko-intel commented Mar 12, 2021

@szha, could you review and merge this forward port from v1.x fix

@szha szha merged commit ece9633 into apache:master Mar 12, 2021
chinakook pushed a commit to chinakook/mxnet that referenced this pull request May 2, 2021
@anko-intel @chinakook
[BUGFIX] Fix AmpCast for float16 (apache#19749) (apache#20003)
fdd6133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anko-intel @mxnet-bot @szha @lanking520