Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix UnicodeDecodeError in method doc (#20214)#20215

Merged
leezu merged 1 commit intoapache:masterfrom
sjiagc:bugfix/fix-unicode-decode-error-on-windows
Apr 26, 2021
Merged

[BUGFIX] Fix UnicodeDecodeError in method doc (#20214)#20215
leezu merged 1 commit intoapache:masterfrom
sjiagc:bugfix/fix-unicode-decode-error-on-windows

Conversation

@sjiagc
Copy link
Contributor

@sjiagc sjiagc commented Apr 25, 2021 •
edited
Loading

Description

On Windows, with package built in VS 2019, the mxnet Python module cannot be imported due to UnicodeDecodeError.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Fix illegal characters in code and doc

Comments

  • Changed '…', '‘' and '’' to "..." and '''.

@mxnet-bot
Copy link

mxnet-bot commented Apr 25, 2021

Hey @sjiagc , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, unix-cpu, sanity, unix-gpu, miscellaneous, website, clang, edge, centos-gpu, windows-cpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 25, 2021
leezu
leezu suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't modify docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

@sjiagc sjiagc force-pushed the bugfix/fix-unicode-decode-error-on-windows branch from bb21482 to 2f8a1d6 Compare April 26, 2021 02:27
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Apr 26, 2021
@sjiagc
Copy link
Contributor Author

sjiagc commented Apr 26, 2021

Please don't modify docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

I see. Reverted change to this file. Thanks for reviewing!

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 26, 2021
@sjiagc
Copy link
Contributor Author

sjiagc commented Apr 26, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Apr 26, 2021

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 26, 2021
@leezu leezu merged commit 2940148 into apache:master Apr 26, 2021
@leezu leezu mentioned this pull request Apr 26, 2021
Closed
@sjiagc sjiagc deleted the bugfix/fix-unicode-decode-error-on-windows branch April 27, 2021 02:50
chinakook pushed a commit to chinakook/mxnet that referenced this pull request May 2, 2021
@sjiagc @chinakook
Avoid UnicodeDecodeError in method doc on Windows (apache#20215)
3be10ad 
Co-authored-by: Tom Shen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham

@szha szha Awaiting requested review from szha

1 more reviewer

@leezu leezu leezu requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjiagc @mxnet-bot @leezu @mseth10