This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Reuse params from cached_op_args#20221
Merged
mseth10 merged 3 commits intoapache:v1.xfrom Apr 28, 2021
Merged
Conversation
|
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [unix-gpu, centos-cpu, windows-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, clang, windows-gpu, sanity] Note: |
leezu
approved these changes
Apr 27, 2021
samskalicky
added a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Apr 28, 2021
* initial commit * fixed handling * fixed formatting Co-authored-by: Ubuntu <ubuntu@ip-172-31-6-220.us-west-2.compute.internal>
mseth10
pushed a commit
that referenced
this pull request
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse the params in
cached_op_argsfor subsequent calls tooptimize_for. Currently, if a new param is added during one call tooptimize_forit is not available for subsequent calls. For example, if you run multiple graph passes then you would need to export/import to get the param. This PR checks ifcached_op_argsis set and reuses those, otherwise it just callscollect_paramslike normal.Also added a check for
backendargument inoptimize_forand cleaned up logic to callhybridizenow that we're using aclearargument to control clearing the cached_graph (whereas before we werent calling hybridize in order to not clear the cached_graph).FYI @Kh4L
Checklist
Essentials
Changes
Comments