This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[operator] Integrate matmul primitive from oneDNN in batch dot#20340
Merged
akarbown merged 5 commits intoapache:masterfrom Jun 24, 2021
Merged
[operator] Integrate matmul primitive from oneDNN in batch dot#20340akarbown merged 5 commits intoapache:masterfrom
akarbown merged 5 commits intoapache:masterfrom
Conversation
|
Hey @bartekkuncer , Thanks for submitting the PR
CI supported jobs: [windows-gpu, centos-gpu, miscellaneous, windows-cpu, unix-cpu, website, unix-gpu, sanity, centos-cpu, clang, edge] Note: |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-testing
bartekkuncer
force-pushed
the
batch_dot
branch
2 times, most recently
from
cfe743f to
bde0545
Compare
mozga-intel
suggested changes
Jun 11, 2021
Contributor
mozga-intel
left a comment
mozga-intel
left a comment
There was a problem hiding this comment.
We need to figure out how to remove the static inline, but otherwise this looks good!
mseth10
added
pr-awaiting-review
mseth10
added
pr-awaiting-testing
Contributor
Author
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
mseth10
added
pr-awaiting-testing
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Aug 4, 2021
…e#20340) * [operator] Integrate matmul primitive from oneDNN in batch dot * Fix test_npx_batch_dot * Remove 'inline static' from BatchDotStorageType * Apply clang-formater * Add static to bool BatchDotStorageType function
chinakook
added a commit
to chinakook/mxnet
that referenced
this pull request
Aug 7, 2021
apache#20340)" This reverts commit ff54582.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change integrates oneDNNs matmul primitive into batch dot execution.
Checklist
Changes