Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Use centos7 base image for CD pipeline and aarch64 build#20423

Merged
mseth10 merged 2 commits intoapache:v1.9.xfrom
waytrue17:v1.9.x
Jul 7, 2021
Merged

[v1.9.x] Use centos7 base image for CD pipeline and aarch64 build#20423
mseth10 merged 2 commits intoapache:v1.9.xfrom
waytrue17:v1.9.x

Conversation

@waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Jul 7, 2021

Description

Backport #20392 #20409.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

mseth10 and others added 2 commits July 7, 2021 13:15
@mseth10
[v1.x] use centos7 base image for aarch64 build (apache#20392)
a142898 
* add centos7 aarch64 build

* enable rh packages

* update openssl curl version

* install rhel7 armpl

* find armpl cmake

* test mkldnn build

* test ninja

* use armpl compiled with gcc-8

* enable py38 for unittests

* check previously failing tests

* create symlink for ninja

* fix cd pypi

* fix cd docker

* update ssl for mac
@waytrue17
[v1.x] Update CD pipeline to build with centos7 (apache#20409)
7fb6d15 
Co-authored-by: Wei Chu <weichu@amazon.com>
@mxnet-bot
Copy link

mxnet-bot commented Jul 7, 2021

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, edge, unix-cpu, miscellaneous, website, clang, unix-gpu, sanity, windows-gpu, centos-cpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jul 7, 2021
Zha0q1
Zha0q1 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jul 7, 2021
mseth10
mseth10 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mseth10 mseth10 merged commit 8b6d392 into apache:v1.9.x Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@mseth10 mseth10 mseth10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@waytrue17 @mxnet-bot @Zha0q1 @mseth10