Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[FEATURE] Load libcuda with dlopen instead of dynamic linking#20484

Merged
mseth10 merged 4 commits intoapache:masterfrom
TristonC:issue-17858
Aug 4, 2021
Merged

[FEATURE] Load libcuda with dlopen instead of dynamic linking#20484
mseth10 merged 4 commits intoapache:masterfrom
TristonC:issue-17858

Conversation

@TristonC
Copy link
Contributor

@TristonC TristonC commented Aug 3, 2021 •
edited
Loading

Description

This PR fixes issue 17858.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Remove cuda_driver library linking for libmxnet.
  • Correct current LibraryInitializer::get_sym API. const char* is used instead of char* for the name parameter.
  • Correct current get_func API accordingly with const char* instead of char* for the name parameter.
  • Call get_sym for all functions from libcuda (functions starting with cu) to dynamically load the symbol and convert them to corresponding function pointers for the src/common/cuda/rtc.cc file.

Comments

@mxnet-bot
Copy link

mxnet-bot commented Aug 3, 2021

Hey @TristonC , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-gpu, miscellaneous, unix-gpu, website, sanity, windows-cpu, clang, windows-gpu, edge, centos-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-work-in-progress PR is still work in progress label Aug 3, 2021
@TristonC
Copy link
Contributor Author

TristonC commented Aug 3, 2021 •
edited
Loading

@ptrendx @leezu @szha Please help review.

@TristonC TristonC marked this pull request as ready for review August 3, 2021 23:38
@TristonC TristonC requested review from leezu and szha as code owners August 3, 2021 23:38
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 3, 2021
@TristonC
Copy link
Contributor Author

TristonC commented Aug 4, 2021 •
edited
Loading

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Jenkins CI successfully triggered : [edge]

@TristonC
Copy link
Contributor Author

TristonC commented Aug 4, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 4, 2021
mseth10
mseth10 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@leezu
Copy link
Contributor

leezu commented Aug 4, 2021

@mxnet-bot run ci [centos-gpu, unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Jenkins CI successfully triggered : [unix-gpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 4, 2021
@TristonC
Copy link
Contributor Author

TristonC commented Aug 4, 2021

@mseth10 The failed centos-gpu test seems flaky.
@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Aug 4, 2021
@szha szha mentioned this pull request Aug 4, 2021
Open
6 tasks
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 4, 2021
@TristonC
Copy link
Contributor Author

TristonC commented Aug 4, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 4, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 4, 2021
@mseth10 mseth10 merged commit e7866d0 into apache:master Aug 4, 2021
@TristonC TristonC deleted the issue-17858 branch August 5, 2021 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leezu leezu Awaiting requested review from leezu leezu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@mseth10 mseth10 mseth10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TristonC @mxnet-bot @leezu @mseth10