Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[DOC][v2.0] Part3: Evaluate Notebooks#20490

Merged
barry-jin merged 29 commits intoapache:masterfrom
barry-jin:eval-notebooks
Aug 17, 2021
Merged

[DOC][v2.0] Part3: Evaluate Notebooks#20490
barry-jin merged 29 commits intoapache:masterfrom
barry-jin:eval-notebooks

Conversation

@barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Aug 5, 2021

Description

Part3 of documentation fixes. Will be included in v2.0.0 beta release #19139
Evaluate notebooks.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Run notebook evaluation on gpu
  • User can add any flaky notebooks into skip_list in md2ipynb.py

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Aug 5, 2021

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, website, windows-gpu, centos-gpu, edge, miscellaneous, unix-gpu, sanity, unix-cpu, windows-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 5, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 6, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 13, 2021
szha
szha approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the important fix!

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Aug 14, 2021
@barry-jin barry-jin mentioned this pull request Aug 14, 2021
Open
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 14, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 16, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 16, 2021

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 16, 2021

Jenkins CI successfully triggered : [centos-cpu]

@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 16, 2021

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 16, 2021

Jenkins CI successfully triggered : [centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 16, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Aug 16, 2021

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Aug 16, 2021

Jenkins CI successfully triggered : [centos-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 16, 2021
@barry-jin barry-jin merged commit 61c3b48 into apache:master Aug 17, 2021
@barry-jin barry-jin deleted the eval-notebooks branch August 17, 2021 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

1 more reviewer

@szha szha szha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barry-jin @mxnet-bot @szha @mseth10