Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[API NEW][ARRAY METHOD] Add __Index__() and __array_namespace__()#20689

Merged
szha merged 5 commits intoapache:masterfrom
barry-jin:other-methods
Nov 1, 2021
Merged

[API NEW][ARRAY METHOD] Add __Index__() and __array_namespace__()#20689
szha merged 5 commits intoapache:masterfrom
barry-jin:other-methods

Conversation

@barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Oct 21, 2021

Description

Add index() and __array_namespace()

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Oct 21, 2021

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-gpu, website, edge, centos-cpu, unix-gpu, windows-gpu, miscellaneous, unix-cpu, windows-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@barry-jin barry-jin mentioned this pull request Oct 21, 2021
Open
52 tasks
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 21, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 21, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 22, 2021

@mxnet-bot run ci [centos-gpu, unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Oct 22, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-gpu, website]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 22, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 22, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
@barry-jin barry-jin changed the title [API] Add __Index() and __array_namespace() [WIP][API NEW][ARRAY METHOD] Add __Index() and __array_namespace() Oct 28, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review labels Oct 28, 2021
@barry-jin barry-jin changed the title [WIP][API NEW][ARRAY METHOD] Add __Index() and __array_namespace() [API NEW][ARRAY METHOD] Add __Index__() and __array_namespace__() Oct 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 30, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 30, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 30, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 31, 2021

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 31, 2021

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 31, 2021
@szha szha merged commit 75e4d1d into apache:master Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barry-jin @mxnet-bot @szha @mseth10