This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v2.0] [BUGFIX] Port #20940 (Upgrade numpy to <1.20.0 ...) from v1.9.x#20957
Merged
DickJC123 merged 5 commits intoapache:masterfrom Mar 18, 2022
Merged
Conversation
…ilities affecting numpy<1.19.1 (apache#20940) * Pin numpy==1.19.1 to demonstrate issues * Relax min numpy version * Make test_np_array_function_protocol delete() testing work with numpy>=1.19 * Fix test_np_delete to also work with numpy>=1.19 * Pip install python module 'packaging' * More pip-install 'packaging' * Update windows requirements.txt * Allow numpy as advanced as 1.19.5
DickJC123
changed the title
mseth10
added
pr-awaiting-testing
samskalicky
approved these changes
Mar 18, 2022
Contributor
samskalicky
left a comment
samskalicky
left a comment
There was a problem hiding this comment.
lgtm, thanks @DickJC123 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ports the unittest fixes of MXNet v1.x PR 20940 to MXNet 2.0. MXNet v1.x used PR 20940 to advance its numpy version from 1.18.5 to numpy 1.19. MXNet 2.0 has already advanced to use numpy 1.19, but did so by skipping the failing tests. Thus, the plan with this PR is to first re-enable the skipped tests, to show them once again failing, then push the fixes to unittests test_np_delete and test_np_array_function_protocol from v1.x PR 20940. In addition, the 3 tests test_np_random_{beta,f,chisquare} need a fix present in v1.x from a different PR.
Checklist
Essentials