Skip to content

Make Instances::default() empty#250

Merged
asny merged 1 commit into
asny:masterfrom
rerun-io:empty-default-instances
May 22, 2022
Merged

Make Instances::default() empty#250
asny merged 1 commit into
asny:masterfrom
rerun-io:empty-default-instances

Conversation

@emilk
Copy link
Copy Markdown
Contributor

@emilk emilk commented May 21, 2022

It is very surprising that Instances::default() isn't empty.
It is very useful to start with the default and add things to it piece-meal.

It is very surprising that Instances::default() isn't empty.
It is very useful to start with the default and add things to it piece-meal.
@emilk emilk mentioned this pull request May 21, 2022
@asny
Copy link
Copy Markdown
Owner

asny commented May 21, 2022

Didn't think that you wanted to create Instances with no instances, but it makes sense if you want to create an empty InstancedMesh and later update the instances. If that makes sense 😂 Anyway, this will break a few of the examples so need to update them before I merge.

@asny asny merged commit 1203753 into asny:master May 22, 2022
@emilk emilk deleted the empty-default-instances branch May 22, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants