Fix ArrayBuffer cloning (util.clone)#59
Merged
Merged
Conversation
Util.clone wasn't able to clone an ArrayBuffer. Firstly, it referenced non-existent variable "source" when it seems that "arg" was actually meant. Secondly, DataView methods setUint8 and getUint8 were wrongly capitalized. The third change (target.byteLength -> arg.byteLength) is just for consistency.
benvanik
added a commit
that referenced
this pull request
Sep 27, 2011
Fix ArrayBuffer cloning (util.clone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Util.clone wasn't able to clone an ArrayBuffer. Firstly, it referenced non-existent variable
sourcewhen it seems thatargwas actually meant. Secondly, DataView methods setUint8 and getUint8 were wrongly capitalized.This should also fix issue #55.