Skip to content

Conversation

@arjankowski
Copy link
Contributor

This PR fixes setting current environment.

Previously configure:environment:set-current wasn't work because bad parameter was used internally.
Instead using args.id the args.name was used which was had unassigned value. As a result, even if the user passed the value, it wasn't detected and user had to choose env from the list.

The second issue was with adding new environment via configure:environment:add command and setting set-as-current flag.
To set created environment as a current we have to save it to environmentsObject and store this by using await this.updateEnvironments(environmentsObj), like we do in set-current.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13676124578

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 85.287%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands/configure/environments/add.js 0 1 0.0%
src/commands/configure/environments/set-current.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 81.03%
Totals Coverage Status
Change from base Build 13052088771: -0.05%
Covered Lines: 4398
Relevant Lines: 4972

💛 - Coveralls

Copy link
Member

@congminh1254 congminh1254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjankowski arjankowski merged commit dc0905f into main Mar 5, 2025
13 checks passed
@arjankowski arjankowski deleted the sdk-4543 branch March 5, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants