Merged
Conversation
Member
|
hmmmm, not sure why the CI is unhappy |
LeeLenaleee
commented
Jan 8, 2024
| }, | ||
| "engines": { | ||
| "pnpm": ">=7" | ||
| "pnpm": ">=8" |
Collaborator
Author
There was a problem hiding this comment.
Seems we need to update this too, not too happy about that but looking at the npm stats it seems like the majority of the user base is already on this version
https://www.npmjs.com/package/pnpm?activeTab=versions
LeeLenaleee
force-pushed
the
update-lockfile
branch
from
fe5a064 to
e34ce24
Compare
Collaborator
Author
|
I think the compressed size fails because it needs to use 2 sepperate versions of pnpm and it does not like that. So it should work in following pr's again. But it is an assumption, couldn't find things about it. |
etimberg
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pnpm changed the lockfile version.
Mr to update it so people can install the codebase again without lockfile changes
resolving: #11627