feat: show a yellow border when staging is active#6819
feat: show a yellow border when staging is active#6819tingwai merged 8 commits intocontinuedev:mainfrom
Conversation
uinstinct
changed the title
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
I think we could make add the text "🚧 staging" (something along those lines) somewhere to replace the yellow line. It won't be immediately clear to a newcomer what the yellow means, especially since when vs code is loading the extension a blue line indicator is shown
| "controlPlane/getEnvironment", | ||
| "controlPlane/getFreeTrialStatus", |
There was a problem hiding this comment.
Nit: move these 2 lines above getModelsAddOnUpgradeUrl line above to keep ordering consistent with other files and mostly alphabetical order
gui/src/components/Layout.tsx
Outdated
| "controlPlane/getEnvironment", | ||
| undefined, | ||
| ); | ||
| console.log("debug2 response was", response); |
|
How about this small yellow dot indicator? |
tingwai
left a comment
tingwai
left a comment
There was a problem hiding this comment.
I like the look of the yellow dot, much cleaner! Just a small adjustment
gui/src/components/Layout.tsx
Outdated
| <LayoutTopDiv> | ||
| {showStagingIndicator && ( | ||
| <div | ||
| title="running on staging" |
There was a problem hiding this comment.
| title="running on staging" | |
| title="Staging environment" |
gui/src/components/Layout.tsx
Outdated
| <AuthProvider> | ||
| <LayoutTopDiv> | ||
| {showStagingIndicator && ( | ||
| <div |
There was a problem hiding this comment.
Let's change this to a span so there's a tooltip on hover
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Description
show a thin yellow border on the top of gui layout when staging is enabled.
resolves CON-2977
Checklist
Screen recording or screenshot
Tests
[ What tests were added or updated to ensure the changes work as expected? ]