Conversation
|
|
||
| describe("TUIChat - Interruption UI (Minimal Test)", () => { | ||
| beforeEach(() => { | ||
| vi.useFakeTimers(); |
Contributor
There was a problem hiding this comment.
Unnecessary use of fake timers in tests; no timer-based behavior is exercised, so this adds complexity without benefit. Consider removing to avoid brittle interactions with async code.
Prompt for AI agents
Address the following comment on extensions/cli/src/ui/__tests__/TUIChat.interruption.minimal.test.tsx at line 9:
<comment>Unnecessary use of fake timers in tests; no timer-based behavior is exercised, so this adds complexity without benefit. Consider removing to avoid brittle interactions with async code.</comment>
<file context>
@@ -0,0 +1,198 @@
+
+describe("TUIChat - Interruption UI (Minimal Test)", () => {
+ beforeEach(() => {
+ vi.useFakeTimers();
+ });
+
</file context>
Contributor
Author
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pause and resume rather than interrupt cn
Summary by cubic
Switches CLI chat interruption from a hard stop to a pause/resume flow so users can press Enter to continue the last response without losing context. Also improves /info to show the current session.