feat: notch cleanup and settings improvements #7667
Merged
Conversation
- Resolved conflicts in core/config/default.ts: kept settings-improvements context providers while adding defaultConfig from main - Resolved conflicts in gui/src/components/AssistantAndOrgListbox/index.tsx: kept ToolTip import from main - Resolved conflicts in gui/src/components/mainInput/InputToolbar.tsx: kept settings-improvements useCodebase logic with main's ToolTip structure and getMetaKeyLabel - Resolved conflicts in gui/src/components/mainInput/Lump/LumpToolbar/BlockSettingsTopToolbar.tsx: removed docs section and used plain string tooltips for tools and MCP sections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Patrick-Erichsen
requested review from
RomneyDa
and removed request for
a team
dosubot
bot
added
the
size:XXL
|
💡 To request a new review, comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
RomneyDa
changed the title
RomneyDa
previously approved these changes
Sep 10, 2025
Collaborator
RomneyDa
left a comment
RomneyDa
left a comment
There was a problem hiding this comment.
Note, already reviewed a few times on original PR (see description) this is the final stamp
RomneyDa
previously approved these changes
Sep 10, 2025
…ettings-improvements-test-fix
github-actions
bot
added
the
tier 1
Contributor
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RomneyDa speaking: I'm changing the base of this to main since I messed up the git history on the original PR
See discussion on original PR here #7561
Summary by cubic
Stabilizes and reorganizes chat tool-call tests to reduce flakiness and improve isolation across edit and parallel tool call scenarios. Tests now configure the mock model via Redux, mock required IDE responses, and split large suites for clarity.
Bug Fixes
Refactors