This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: check for empty input unit strings#1475
Merged
jonboulle merged 2 commits intocoreos:masterfrom Mar 10, 2016
Merged
Conversation
Contributor
|
@dongsupark could you please rebase this one! |
dongsupark
force-pushed
the
dongsu/fleetctl-error-empty-units
branch
from
e613e8c to
69abb9f
Compare
Author
|
@tixxdz rebased. |
Contributor
|
thanks! lgtm |
Contributor
|
nit: Can you reorder the commits? Add the tests, then the new code. That way, it's clear that the new code isn't changing behaviour from the existing.. |
added 2 commits
March 10, 2016 10:54
Check that the return value is 0, when the following commands run without any input unit names: destroy, load, start, stop, and unload.
If no unit name is given for fleetctl commands like destroy, load, start, stop, submit, and unload, then return with exit code 0, printing out a soft warning message to stderr. Fixes: coreos#1443
dongsupark
force-pushed
the
dongsu/fleetctl-error-empty-units
branch
from
69abb9f to
80d37bb
Compare
Author
|
@jonboulle done. |
Contributor
|
@jonboulle I guess this one reached its final form ? if so feel free to merge it, otherwise just ignore and I'll do it later. Thank you! |
jonboulle
added a commit
that referenced
this pull request
Mar 10, 2016
fleetctl: check for empty input unit strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no unit name is given for fleetctl commands like destroy, load,
start, stop, submit, and unload, then return with exit code 0,
printing out a soft warning message to stderr.
Fixes: #1443
/cc @kayrus @tixxdz @jonboulle
(A new revision of #1461)