Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Move to cli#1570

Closed
reneengelhard wants to merge 2 commits intocoreos:masterfrom
endocode:reneengelhard/cli
Closed

Move to cli#1570
reneengelhard wants to merge 2 commits intocoreos:masterfrom
endocode:reneengelhard/cli

Conversation

@reneengelhard
Copy link
Contributor

@reneengelhard reneengelhard commented Apr 26, 2016

Hi,

while discussing #1453 and the implications of fixing it we thought it would make sense to move from our custom flag parsing to use 'cli' - as etcd already does.

Due to some difficulties and big(ger) restructuring needs of (test) code it took longer than anticipated, but here it is.

Passes the unit and functional tests. I rebased it upto current master so it includes the new
--replace switch, too

Regards,

Rene

@reneengelhard reneengelhard mentioned this pull request Apr 26, 2016
Closed
@reneengelhard
move to cli
c56d5e1 
- rework option parsing
- move away from (most) global variables (cAPI), keep currentCommand for now...
- we need to pass c (the cli context) and cAPI (the client API) around

Signed-off-by: Olaf Buddenhagen <olaf@endocode.com>
@tixxdz
Copy link
Contributor

tixxdz commented Apr 26, 2016

@reneengelhard @antrik thanks for the work!

So if tests pass, we need some lgtm here, will review it later. If of course there are no backward incompatibilities this should go in.

Thanks again!

@jonboulle
Copy link
Contributor

jonboulle commented Apr 26, 2016

nack, if you're going to move to a library can you please make it cobra
instead? https://github.com/coreos/docs/tree/master/golang#cli

We used to use codegangsta in fleet and moved away from it. If you look
into etcd a little deeper, it should only be using cli for some old
commands, and all the latest stuff should be using cobra.

On Tue, Apr 26, 2016 at 3:44 PM, Rene Engelhard notifications@github.com
wrote:

Hi,

while discussing #1453 #1453 and
the implications of fixing it we thought it would make sense to move from
our custom flag parsing to use 'cli' - as etcd already does.

Due to some difficulties and big(ger) restructuring needs of (test) code
it took longer than anticipated, but here it is.

Passes the unit and functional tests. I rebased it upto current master so
it includes the new
--replace switch, too

Regards,

Rene

You can view, comment on, or merge this pull request online at:

#1570
Commit Summary

  • Godeps: add github.com/codegangsta/cli
  • move to cli

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1570

@tixxdz
Copy link
Contributor

tixxdz commented Apr 27, 2016

@jonboulle just in time, alright.

@tixxdz tixxdz closed this Apr 28, 2016
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 13, 2016
fleetctl: convert cli to cobra
1bf8f39 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* do not pass around cAPI all the time, but create a parameter API for
  each run command, to wrap around cases from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
@dongsupark dongsupark mentioned this pull request May 13, 2016
Merged
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 13, 2016
fleetctl: convert cli to cobra
305b049 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* do not pass around cAPI all the time, but create a parameter API for
  each run command, to wrap around cases from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 14, 2016
fleetctl: convert cli to cobra
4dcf9a1 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* do not pass around cAPI all the time, but create a parameter API for
  each run command, to wrap around cases from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 14, 2016
fleetctl: convert cli to cobra
d63a113 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 14, 2016
fleetctl: convert cli to cobra
96c9f42 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 14, 2016
fleetctl: convert cli to cobra
fd3f1b6 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 14, 2016
fleetctl: convert cli to cobra
48d7d6d 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 17, 2016
fleetctl: convert cli to cobra
372f16a 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 17, 2016
fleetctl: convert cli to cobra
3df5692 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to endocode/fleet that referenced this pull request May 19, 2016
fleetctl: convert cli to cobra
431f0c7 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to endocode/fleet that referenced this pull request May 19, 2016
fleetctl: convert cli to cobra
91d0e20 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* create a parameter API for each run command, to wrap around cases
  from different contexts.
* create a wrapper runWrapper() to be used for cobra.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 20, 2016
fleetctl: convert cli to cobra
b38705e 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* Create a wrapper runWrapper() to be used for cobra, to wrap around
  a normal run*() function into a prototype for cobra.Command.Run().
  It also sets a global variable cAPI for running a normal command.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
dongsupark pushed a commit to dongsupark/fleet that referenced this pull request May 20, 2016
fleetctl: convert cli to cobra
848d356 
Use Cobra (github.com/spf13/cobra) instead of cli
(github.com/codegangsta/cli), for better cmdline user interface.

* Create a wrapper runWrapper() to be used for cobra, to wrap around
  a normal run*() function into a prototype for cobra.Command.Run().
  It also sets a global variable cAPI for running a normal command.
* remove unnecessary code for codegangsta/cli from fleetctl.go.

Suggested-by: Jonathan Boulle <jonathanboulle@gmail.com>
Fixes: coreos#1453
Supersedes coreos#1570
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reneengelhard @tixxdz @jonboulle