This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetd,main: make github.com/coreos/fleet go-getable#1681
Merged
dongsupark merged 2 commits intocoreos:masterfrom Sep 14, 2016
Merged
fleetd,main: make github.com/coreos/fleet go-getable#1681dongsupark merged 2 commits intocoreos:masterfrom
dongsupark merged 2 commits intocoreos:masterfrom
Conversation
So far it hasn't been possible to do "go get github.com/coreos/fleet" because there was no main.go in the top source directory. Create main.go, a simple wrapper for fleetd to make it "go-getable".
Now that fleetd/fleetd.go doesn't have main(), we need to make the default build script run go build on the top source directory, instead of ./fleetd/. Then it will end up building fleetd, as main() in main.go imports fleetd.Main() by default.
Contributor
|
LGTM if everything else continues to work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far it hasn't been possible to do
"go get github.com/coreos/fleet"because there was no main.go in the top source directory. Create main.go, a simple wrapper for fleetd to make it "go-getable".This is a preparation for #1665, as
goacirequires a go-getable package.